added: new functionality to be able to create a drag-handle #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry.. but I'm not that good with Git so needed to make a new PR. Made the changes like you asked. |
sunpietro
reviewed
Dec 8, 2016
| @@ -479,6 +480,12 @@ | |||
| * @param event {Object} event object | |||
| */ | |||
| mousedown: function (event) { | |||
| if (finalParams.dragHandleCssClass && | |||
There was a problem hiding this comment.
if (finalParams.dragHandleCssClass &&
(typeof finalParams.dragHandleCssClass !== 'string' ||
!event.target.classList.contains(finalParams.dragHandleCssClass))) {
return false;
}
|
Sorry.. but I don't get this stupid Git, I make the change you suggest on my local branch, Really don't know what I'm doing wrong. |
sunpietro
reviewed
Dec 8, 2016
| @@ -481,8 +481,8 @@ | |||
| */ | |||
| mousedown: function (event) { | |||
| if (finalParams.dragHandleCssClass && | |||
| typeof finalParams.dragHandleCssClass === 'string' && | |||
| !event.target.classList.contains(finalParams.dragHandleCssClass)) { | |||
| (typeof finalParams.dragHandleCssClass === 'string' || | |||
There was a problem hiding this comment.
typeof finalParams.dragHandleCssClass !== 'string'
|
Fixed, my bad. |
sunpietro
approved these changes
Dec 9, 2016
|
@Webtrix Thank you for your commitment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a really simple addition, so a drag handle can be created. Only when the mouse down event happend on this
elementthe dragging will fire.